[arm-allstar] IaxRpt Client Dropping after update

[David McGough]

Thanks Stan.  Yes, this code is complex, for sure.  Not only must it run
in real-time, but the core data structures were written in an era when
multi-core processors were much less common place. An era where concurrent
multiprocessing race conditions were more of a theory, rather than
something which is constant reality--even on a $35 RPi2/3 board!

As I've said to fellow C programmers in the past: Just because the manual
page says that a function is "Thread Safe," that DOES NOT automatically
mean the function is concurrent multiprocessing safe!


73, David KB4FXC


On Tue, 3 Apr 2018, Stanley Stanukinos wrote:

> David, thank you to you and Doug for all the programming and testing 
work you both do. It is a thankless job that a lot of people do not 
understand how difficult it is to do. All the testing of different 
iterations of equipment and configurations of the software that have to 
be regression tested as well as the development of the newer code to 
support the later version Pie's. 
> 
> Stan
> 
> Sent from my iPhone
> 
> > On Apr 3, 2018, at 9:05 AM, David McGough via arm-allstar <arm-allstar at hamvoip.org> wrote:
> > 
> > 
> > Hi again,
> > 
> > Okay, I've got a work-around resolution for IaxRpt devices. If they show 
> > up as a node "0", the one way audio test is disabled.
> > 
> > I realize that IaxRpt devices could have a node number other than "0". In 
> > that case, the software will still generate error messages, but will also 
> > reconnect promptly. I'll investigate a better solution.
> > 
> > I will ultimately have an actual fix for the one way audio issue, rather 
> > than just detect & correct; I believe I have identified the cause. The 
> > "proper" fix will take a bit of effort to implement.
> > 
> > 
> > 73, David KB4FXC
> > 
> > 
> > 
> >> On Tue, 3 Apr 2018, "David McGough via arm-allstar" wrote:
> >> 
> >> 
> >> Hi Everyone,
> >> 
> >> Shoot. I didn't test the IaxRpt client. And, I understand WHY it won't 
> >> stay connected, with the current One way audio patch.
> >> 
> >> I can fix this, since the IaxRpt devices show up with a 
> >> node number of "0" -- I'll just disable the test.
> >> 
> >> I'll send an update out shortly and send another e-mail.
> >> 
> >> 73, David KB4FXC
> >> 
> >> 
> >> 
> >>> On Mon, 2 Apr 2018, "James R. Pilgram via arm-allstar" wrote:
> >>> 
> >>> Doug, Dave.
> >> 
> >> Did the update and now none of the nodes that I updated will stay 
> >> connected to the IaxRpt client. I have some older nodes that aren't 
> >> updateable and there's no problem with them. The stay connected.
> >> 
> >> Here's a cut and paste of the CLI.
> >> 
> >> Jim NH6HI
> >> 
> >> 
> >> Connected to Asterisk 
> >> 1.4.23-pre.hamvoip-V1.5.3-26-app_rpt-0.327-04/03/2018 currently running 
> >> on wh6fg_hub (pid = 27941)
> >> Verbosity is at least 4
> >>     -- Accepting AUTHENTICATED call from 192.168.1.124:
> >>        > requested format = ulaw,
> >>        > requested prefs = (),
> >>        > actual format = alaw,
> >>        > host prefs = (alaw|ulaw|gsm),
> >>        > priority = mine
> >>     -- Executing [29277 at radio-iaxrpt:1] Rpt("IAX2/iaxrpt-3297", 
> >> "29277|X") in new stack
> >>   == Spawn extension (radio-iaxrpt, 29277, 1) exited KEEPALIVE on 
> >> 'IAX2/iaxrpt-3297'
> >> [Apr  2 23:34:06] ERROR[28041]: app_rpt.c:18580 rpt: No link frames from 
> >> [0] in 46 seconds -- One way audio??? Forcing reconnect.
> >>     -- Hungup 'IAX2/iaxrpt-3297'
> >>     -- Hungup 'DAHDI/pseudo-297655478'
> >>     -- Remote UNIX connection
> >>     -- Remote UNIX connection disconnected
> >>     -- Remote UNIX connection
> >>     -- Remote UNIX connection disconnected
> >>     -- Remote UNIX connection
> >>     -- Remote UNIX connection disconnected
> >>     -- Remote UNIX connection
> >>     -- Remote UNIX connection disconnected
> >> wh6fg_hub*CLI>
> >> 
> > 
> > _______________________________________________
> > 
> > arm-allstar mailing list
> > arm-allstar at hamvoip.org
> > http://lists.hamvoip.org/cgi-bin/mailman/listinfo/arm-allstar
> > 
> > Visit the BBB and RPi2/3 web page - http://hamvoip.org
> 
>